-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use "avocado-latest-release" repository #6057
Use "avocado-latest-release" repository #6057
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6057 +/- ##
==========================================
+ Coverage 68.68% 68.69% +0.01%
==========================================
Files 203 203
Lines 21970 21970
==========================================
+ Hits 15089 15092 +3
+ Misses 6881 6878 -3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @clebergnu, changes LGTM, thanks. Maybe could you please also update our next release notes in https://github.com/avocado-framework/avocado/blob/master/docs/source/releases/next.rst to not forget to mention this change during the release? What do you think?
0be736c
to
ae82a4d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @clebergnu, thanks for the update. I have one more comment to release notes. Please have a look.
ae82a4d
to
a2d1fd6
Compare
"description": "Log into https://copr.fedorainfracloud.org/coprs/g/avocado/avocado-latest-release/add_build/ and submit a new build using SCM as the source type, the clone URL being https://github.com/avocado-framework/avocado.git, the committish being the version tag (such as 109.0) and make srpm as the mechanism to build a SRPM." | ||
}, | ||
{ | ||
"name": "Update the Fedora RPM packages", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIUIC this part should be removed, am I right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, that's actually the replacement for the old instructions. This will trigger (manually, on every release) a build of the latest release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@clebergnu Sorry, I am still confused. The description links to https://avocado-framework.readthedocs.io/en/latest/guides/contributor/chapters/releasing.html#how-to-refresh-fedora-epel-modules
but this part of documentation is removed in this PR, or I am missing something?
In both the installation instructions, and in the release guide. This reflects changes in distros and the availability of features such as Fedora (and EPEL) modules. Fixes: avocado-framework#6044 Reference: https://fedoraproject.org/wiki/Changes/RetireModularity Signed-off-by: Cleber Rosa <crosa@redhat.com>
a2d1fd6
to
68f6133
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks
In both the installation instructions, and in the release guide.
This reflects changes in distros and the availability of features such as Fedora (and EPEL) modules.
Fixes: #6044
Reference: https://fedoraproject.org/wiki/Changes/RetireModularity